fix[notask]: remove NPM_TOKEN usage from sdk publish workflow#1849
Merged
Conversation
The publish step now uses npm trusted publishing (OIDC), so the legacy NPM_TOKEN auth in the build step's .npmrc and bunfig.toml is no longer needed. @qvac/* packages on npmjs.org are public, so anonymous reads work for installs. Aligns with #1618 (DEVOPS-2062) which migrated the publish step to trusted publishing but left the build-step NPM_TOKEN references in place.
tamer-hassan-tether
approved these changes
May 1, 2026
Contributor
Author
|
/review |
Contributor
Tier-based Approval Status |
lauripiisang
approved these changes
May 1, 2026
Contributor
Author
|
/review |
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
The publish step now uses npm trusted publishing (OIDC), so the legacy NPM_TOKEN auth in the build step's .npmrc and bunfig.toml is no longer needed. @qvac/* packages on npmjs.org are public, so anonymous reads work for installs. Aligns with #1618 (DEVOPS-2062) which migrated the publish step to trusted publishing but left the build-step NPM_TOKEN references in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: be concise and prefer bullet points.
🎯 What problem does this PR solve?
release-sdk-*was failing because the workflow still wiredNPM_TOKENinto.npmrc/bunfig.tomlduring build, even though the publish step migrated to npm trusted publishing in DEVOPS-2062: refactor to use npm trusted publishing and remove NPM_TOKEN #1618 (DEVOPS-2062).id-token; the legacyNPM_TOKENis now unnecessary noise that obscures the real auth path.📝 How does it solve it?
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}(and the deadGPR_TOKEN) from the build job's "Configure scoped registry" step.//registry.npmjs.org/:_authToken=${NPM_TOKEN}from the generated.npmrc.@qvacscope override from the generatedbunfig.toml(default registry already points atregistry.npmjs.org/, and@qvac/*packages are public on npm so no token is needed for reads).@tetherto/ GitHub Packages auth (GIT_PAT/READ_NPM_TOKEN) intact — those packages are private on GHP.🧪 How was it tested?
@qvac/sdkis publicly readable onregistry.npmjs.org/without auth (npm view @qvac/sdkresolves anonymously), so the SDK's@qvac/*deps install fine without a token.diffusion-cpp) through the same trusted-publishing path with Node 24.14.1 / npm 11.11.0.Note
This fix needs to also land on
release-sdk-0.10.0for Monday's SDK release. Cherry-pick after merge.